SSL Root Certificate Examples#2872
Open
chernser wants to merge 2 commits into
Open
Conversation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4ac5a16. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
client-v2andjdbcprojects and use testcontainer with specially configured server. Also allows run against user configured endpointThis PR is part 1 in series of changes for SSL support and different configurations.
Checklist
Delete items not relevant to your PR:
Note
Medium Risk
HttpAPIClientHelper drops the SPI-style SSL provider in favor of a fixed default implementation, which is a small TLS wiring change in production code; most of the PR is examples and tests.
Overview
Adds client-v2 and JDBC runnable examples for HTTPS when the server chain is signed by a private CA, using
setRootCertificate/sslrootcertwithout a JVM trust store. Local runs spin up Docker ClickHouse with ephemeral certs via newSSLExamplesandSecureServerSupport; standalone mode targets a user-supplied host and CA PEM path. READMEs document both modes and manual OpenSSL/Docker setup.client-v2 gains an integration test (
testCustomCaCertificate) that builds a CA-signed server cert, serves HTTPS with WireMock, and asserts a client with only the root CA can ping/query while the default-trust client fails. HttpAPIClientHelper wires TLS through an instance ofClickHouseDefaultSslContextProviderinstead of the pluggableClickHouseSslContextProviderlookup (behavior for trust store vs cert paths unchanged). Test/example modules add BouncyCastle and Testcontainers;.gitignoreignores generated cert/key artifacts.Reviewed by Cursor Bugbot for commit 4ac5a16. Bugbot is set up for automated code reviews on this repo. Configure here.